KarpelesLab / goro / 25341140909

13%

Build Type

push

github

Committed by MagicalTux

Commit Message

vm: native string interpolation, by-ref builtin fallback, \$this checks

Adds native lowering of compiler.runConcat (the AST node
produced for "string \$var" interpolation) to a chain of
N-1 OP_CONCAT instructions on top of the loaded parts.

Side-effects of unblocking these scripts (they used to fall
back at compile time because runConcat was unrecognized)
exposed several latent issues, all fixed in this commit:

- emit_call: short-circuit ErrUnsupported when calling a
  builtin that takes a by-ref argument (end, sort, ksort,
  array_walk, array_push/pop/shift/unshift, array_splice,
  array_multisort, settype, parse_str, mb_parse_str,
  preg_match, preg_match_all, sscanf, …). The VM's value-
  passing call protocol can't bind a Writable, so these
  callers fall back to AST.

- emit_stmt: always emit OP_TICK at statement boundaries —
  even when the node doesn't expose a Loc() — so
  ctx.Loc() is updated and exception constructors record
  the right file:line. Also wire funcCallNode loc into
  the stmtLoc helper.

- vm.go: \$this is special. OP_LOAD_LOCAL[_OR_WARN] now
  throws "Using \$this when not in object context" when the
  slot is missing AND ctx.This() is nil — matches the AST
  runVariable.Run path.

- ops_try / vm.go: dispatchTryHandler returns a (handled,
  newErr) pair. When binding the catch variable triggers a
  destructor that throws (PHP bug 53511 semantics), the
  outer dispatch loop swaps to the new exception and
  re-attempts handler lookup.

Bench impact (vs. AST baseline):
  Arithmetic    ~ -44%  (was -50% before — slot-only is
                          gated more conservatively now)
  Fibonacci     ~ -20%
  ArrayOps      ~ -23%
  StringConcat  ~ -19%  (interp + slot-only)
  FunctionCalls flat

phpt under GORO_VM=1: 25 regressions (was 19 pre-interp).
The +6 are by-ref-on-user-function and destructor-chain
edge cases the value-passing call protocol can't replicate.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Coverage Stats

44 of 81 new or added lines in 7 files covered. (54.32%)

2 existing lines in 1 file now uncovered.

9810 of 114655 relevant lines covered (8.56%)

1011.31 hits per line