KarpelesLab / goro / 25339530035

13%

Build Type

push

github

Committed by MagicalTux

Commit Message

vm: native try/catch (no finally yet)

Adds Function.TryHandlers + CatchClause as static metadata
attached to each compiled function. The dispatcher's outer
loop catches PhpThrow and scans handlers for one whose
[Start, End) range covers the failing PC; for each catch
clause it checks the exception class against the declared
type list and binds the exception variable to the local
slot. Forward iteration finds the innermost handler first
(nested tries register inner-then-outer).

Out of scope for this round:
- finally clauses (try with finally still falls back via
  ErrUnsupported)
- the special pass-through behaviour for return/break/
  continue inside a try with finally

The dispatch loop has been split into runUntilError (the
inner switch) and exec (the outer wrapper that handles
try-handler dispatch). Errors from any opcode bubble up
through runUntilError; the outer wrapper either catches
the exception via dispatchTryHandler or propagates it.

Tests cover: no-throw try, single catch, type-mismatch
falling through to outer, nested try, catch without var,
exception in catch body propagating to outer, multiple
catch clauses (second matches), and union-type catches
(`catch (A | B \$e)`). Still zero new phpt regressions
under GORO_VM=1.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Coverage Stats

106 of 186 new or added lines in 6 files covered. (56.99%)

2 existing lines in 1 file now uncovered.

9665 of 114543 relevant lines covered (8.44%)

966.62 hits per line