ben-manes / caffeine / #5435

100%

master: 100%

push

github

audit follow-ups: sketch sentinel guard, async asMap setValue, tests

* BoundedLocalCache.AddTask.run / evictionOrder: read keyRef first then
  check isAlive() before incrementing the frequency sketch, so a retired
  strong-key sentinel cannot pollute the sketch (matches onAccess pattern).

* LocalAsyncCache.AsyncAsMapView.entrySet(): wrap with a custom EntrySet
  whose iterator/spliterator yields WriteThroughEntries backed by
  AsyncAsMapView itself, so setValue routes through AsyncAsMapView.put and
  handleCompletion runs on completion (weight, expiry, stats, null/error
  auto-removal). removeAll/retainAll/contains/remove still delegate to BLC's
  optimized entrySet to preserve weak-key identity semantics. Updated the
  existing writeThroughEntry and entrySet_toArray_writeThrough tests for the
  new stats and added writeThroughEntry_incompleteFuture.

* simulator/build.gradle.kts: add withPathSensitivity(RELATIVE) to the two
  inputs.files declarations on JavaExec tasks.

* New BoundedLocalCacheTest coverage from /audit-* findings:
  brokenEquality_{compute,computeIfAbsent,merge};
  compute_collectedEntry_mappingThrows_evictionCommitted and
  computeIfAbsent_collectedEntry_mappingThrows_evictionCommitted as
  COLLECTED-side parallels to the existing EXPIRED variants;
  compute_{expired,collected}Entry_weigherThrows_evictionCommitted; and
  replaceConditionally_weigherThrows_wrongOldValue as a regression guard
  for the deliberate decision to keep the weigher call outside the bin's
  critical section.

* AsyncCacheFrayTest.refresh_concurrentEvictionAndReadd exercises the
  LocalAsyncLoadingCache.refresh(K) for(;;) loop under concurrent
  eviction-and-re-add (10,000 iterations).

3950 of 3958 branches covered (99.8%)

40 of 40 new or added lines in 2 files covered. (100.0%)

8089 of 8089 relevant lines covered (100.0%)

1.0 hits per line