mindersec / minder / 25334664832
60%

DEFAULT BRANCH: main
Ran
Jobs 1
Files 346
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 60.442% (-0.1%) from 60.56%
25334664832

push

github

web-flow 
Generalize identity provider and implement OIDC discovery (#6265)

* feat(auth): generalize identity provider and implement OIDC discovery

This commit decouples Minder from Keycloak-specific paths by:
- Implementing OIDC discovery for identity server configuration.
- Defining the IdentityManager interface for administrative operations.
- Refactoring event synchronization and user management to use the new interface.
- Removing legacy Keycloak-specific configuration helpers.
- Updating tests to use the generalized IdentityManager mock.

* chore(auth): fix linting and unit test regressions in identity refactor

- Fix duplicate DeleteUser call in handlers_user.go
- Resolve linting issues (unused receivers, missing docs) in interface.go
- Update tests to properly inject MockIdentityManager

* chore(auth): fix linting and add missing unit/integration tests

* refactor(auth): address PR maintainer feedback for IdentityProviders

- Use zitadel/oidc generic client for openid configuration discovery
- OIDC issuer claim matches the discovered client issuer output
- Add missing GitHub IDs clarification
- Include TODOs about unused methods for tracking

* fix(auth): address additional code review feedback

- Fix strings.Contains on ErrNotFound
- Export auth.ErrNotFound
- Restore removed TODO in token handler
- Remove noop test to exclude from coverage as requested
- Discard unintentional metrics/version test commits
- Remove obsolete httptest.NewServer loops

* feat: Add ResolveFederated to auth interface for generic OIDC support

* fix: use issuer_claim for WWW-Authenticate header and accept dual issuer URLs in docker-compose

* style: fix gci formatting in keycloak files

36 of 167 new or added lines in 11 files covered. (21.56%)

1 existing line in 1 file now uncovered.

20396 of 33745 relevant lines covered (60.44%)

38.8 hits per line

Uncovered Changes

Lines Coverage ∆ File
57
54.04
 -25.27% internal/auth/keycloak/keycloak.go
43
47.86
 -27.81% internal/auth/interface.go
8
0.0
 0.0% internal/auth/github.go
6
33.33
 -66.67% internal/util/ptr/ptr.go
5
0.0
 0.0% internal/service/service.go
4
56.25
 -0.2% internal/controlplane/identity_events.go
3
90.0
 -10.0% internal/auth/githubactions/githubactions.go
3
4.11
 0.0% internal/controlplane/handlers_token.go
1
1.55
 -0.0% internal/controlplane/server.go
1
89.66
 22.99% pkg/config/server/identity.go

Coverage Regressions

Lines Coverage ∆ File
1
54.04
 -25.27% internal/auth/keycloak/keycloak.go
Jobs
ID Job ID Ran Files Coverage
1 25334664832.1 346
60.44
 GitHub Action Run
Source Files on build 25334664832