stacklok / toolhive-studio / 25325632082

67%

main: 71%

Build Type

Pull #2184

github

Committed by samuv

Commit Message

fix(playground): prune stale enabled skills on every refresh

Closes the picker prune gap flagged by review on #2184. Previously the only prune path lived inside the Skill Engineer bundle and was guarded by `if (result.skills.length > 0)`, which meant:

- Uninstalling a skill left its row in `enabled_skills` until an agent happened to fire `list_skills`.

- The renderer never invoked the prune helper, so the picker advertised "prune on next picker resync" without actually doing it.

- `Clear enabled skills` iterated `availableSkills` (joined view), so a stale row whose skill is no longer installed was invisible to the button — the count dropped to 0 and the action disabled itself, leaving the row stuck.

Now `chat:get-enabled-skills` accepts an optional `installedNames` argument; when present, the main process prunes against it before reading. `useAvailableSkills` chains the two queries — once the installed-skills query resolves, the install-name set goes into the `enabled-skills` queryKey, so any install / uninstall automatically refetches and re-prunes in one round-trip. Server-side, the `result.skills.length > 0` guard is dropped: only an actual fetch error skips pruning, so a successful empty response (user uninstalled their last skill) correctly wipes the allow-list.

`SkillSelector` now iterates the raw `enabledNames` for clear-all, so it can wipe stale rows even before the next prune lands. Adds dedicated IPC handler tests, hook test for the install-name hint, and flips the bundle test that previously asserted the broken guard.

Co-authored-by: Cursor <cursoragent@cursor.com>

Pull Request Pull Request #2184: feat(playground): installed-skills picker and unified Skill Engineer agent

Coverage Stats

4477 of 7351 branches covered (60.9%)

264 of 346 new or added lines in 13 files covered. (76.3%)

3 existing lines in 1 file now uncovered.

6840 of 10232 relevant lines covered (66.85%)

120.09 hits per line