KarpelesLab / goro / 25322184655

13%

Build Type

push

github

Committed by MagicalTux

Commit Message

vm: add OP_CALL_USER for user/builtin function calls

The emitter now lowers *runnableFunctionCall (positional-args
form) to OP_CALL_USER. The dispatch handler pops argc args
off the VM stack, looks up the callable by name, and invokes
it via ctx.CallZVal — same path the AST already uses. Result
goes back on the VM stack.

VM and AST functions can call each other freely:
- VM-compiled bytecode → AST function: works via CallZVal
- AST function → VM-compiled wrapper: works via the Runnable
  contract (already in place from Commit 2)

Out of scope (returns ErrUnsupported, falls back to AST):
named arguments (f(name: 1)), spread (f(...$arr)), variable
function calls ($f()). By-ref param wiring is also out of
scope: the VM passes pre-evaluated ZVals, so a callee with
&$x param won't see caller mutations. We'll harden that in a
later commit (or just accept it once arrays/objects land).

Tests cover positional calls, a 10-iteration for-loop calling
a user-defined function each iteration, builtin strlen(), and
recursive Fibonacci fib(10) — all asserting AST and VM
return identical results.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Coverage Stats

41 of 70 new or added lines in 5 files covered. (58.57%)

61 existing lines in 3 files now uncovered.

6323 of 113335 relevant lines covered (5.58%)

617.88 hits per line