KarpelesLab / libwallet / 25319544056

24%

Build Type

push

github

Committed by MagicalTux

Commit Message

wlttx/bitcoin: priority field selects cheap vs fast fee budget

Lets the user pick whether they want the tx to be cheap or fast.
Same shape Solana already uses — the PriorityLevel string
("low" / "medium" / "high"). Bitcoin maps it to
estimatesmartfee's confirmation target:

  "low"           → 144 blocks  (cheap, hours)
  "" / "medium"   →  6 blocks  (default)
  "high"          →  2 blocks  (fast)

MaxSendableRequest grows a Priority field that flows into
the bitcoin path; the returned BitcoinFeeRate carries the
resolved sat/vB so the caller can pin it on the build call (or
use UnsignedTransaction.maxSend which threads it for them).

buildBitcoinTx fee-rate resolution order:
  1. tx.BitcoinFeeRate  (pinned — wins)
  2. estimatesmartfee at the conf target tx.PriorityLevel maps to
  3. 10 sat/vB fallback on RPC error

Dart side:
  - transactions.maxSendable() takes optional `priority`
  - UnsignedTransaction.priorityLevel doc updated to mention
    bitcoin's mapping (it was Solana-only before)

Tests pin the priority → conf target mapping so a future
"let's flip low and high" refactor lands loud.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Coverage Stats

7 of 20 new or added lines in 2 files covered. (35.0%)

349 existing lines in 3 files now uncovered.

3203 of 15298 relevant lines covered (20.94%)

124.73 hits per line