KarpelesLab / libwallet / 25315969566

24%

Build Type

push

github

Committed by MagicalTux

Commit Message

wlttx/bitcoin: collapse to a single UTXO fetcher (modchain_assets)

Two parallel fetchers were one too many. fetchBitcoinAllUTXOs
(modchain_assets) already returned everything needed: the txo
ref, the path (so we know which signing key to derive),
the script type (so we know the input vsize), and the amount.
The per-path fetchBitcoinUTXOs (modchain_lookupTxoBIP32) was
only kept around for change-index discovery via lookupTxo's
per-path lastI field — but that's derivable from the same
data: walk the unspent set's m/1 entries, max+1.

Drops:
  - the per-path modchain_lookupTxoBIP32 wrapper
  - the bitcoinTxoResp struct (unused after the wrapper goes)
  - the second RPC call buildBitcoinTx and simulate's dry-run
    were making to discover the next change index

Renames fetchBitcoinAllUTXOs → fetchBitcoinUTXOs (only one
fetcher, no need to disambiguate). New nextChangeIndex(utxos)
helper does the m/1 max-index walk; documented caveat about
fully-spent change history landing back at 0.

Tests pin the change-index walk and the txid byte order from
the previous commit.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Coverage Stats

9 of 18 new or added lines in 4 files covered. (50.0%)

12 existing lines in 2 files now uncovered.

3196 of 15271 relevant lines covered (20.93%)

123.84 hits per line