tari-project / tari / 25304980873
61%

DEFAULT BRANCH: development
Ran
Jobs 1
Files 702
Run time 2min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 60.968% (-0.05%) from 61.022%
25304980873

push

github

web-flow 
test: add standalone offline signer cucumber coverage (#7792)

Description
---
Adds standalone `minotari_offline_signer` coverage to the offline
one-sided transaction cucumber feature.

This introduces a library entrypoint for the offline signer CLI and a
`test-keystore` feature with a hidden file-backed keystore option so
cucumber can exercise signer init/sign flows deterministically without
relying on OS keyring services in CI.

Motivation and Context
---
Closes #7785.

The existing offline signing cucumber scenario signs through the console
wallet CLI. This adds a separate scenario that:
- initializes the standalone offline signer from the sender wallet seed
words
- prepares a transaction from a view-only wallet
- signs the prepared transaction with the standalone signer
- broadcasts via the view wallet and verifies receiver funds

How Has This Been Tested?
---
- `cargo check --locked --ignore-rust-version -p minotari_offline_signer
--all-features`
- `PATH="/opt/homebrew/opt/libtool/libexec/gnubin:$PATH" cargo check
--locked --ignore-rust-version -p tari_integration_tests --test
cucumber`
- `PATH="/opt/homebrew/opt/libtool/libexec/gnubin:$PATH" cargo test
--locked --ignore-rust-version -p tari_integration_tests --test cucumber
--no-run`
- `../target/debug/deps/cucumber-8e26c7f49d7fa52a --tags
@standalone-offline-signer --concurrency 1 --fail-fast` from
`integration_tests/` passed: 1 scenario, 17 steps.

What process can a PR reviewer use to test or verify this change?
---
From the workspace root:

```bash
cargo check --locked --ignore-rust-version -p minotari_offline_signer --all-features
cargo check --locked --ignore-rust-version -p tari_integration_tests --test cucumber
cargo test --locked --ignore-rust-version -p tari_integration_tests --test cucumber --no-run
```

Then run the standalone scenario from `integration_tests/`:

```bash
../target/debug/deps/cucumber-<hash> --tags @standalone-offline-signer --concurrency 1 --fail-fast
```

Breaking C... (continued)

0 of 148 new or added lines in 2 files covered. (0.0%)

18 existing lines in 7 files now uncovered.

70848 of 116206 relevant lines covered (60.97%)

223647.6 hits per line

Uncovered Changes

Lines Coverage ∆ File
136
0.0
 0.0% applications/minotari_offline_signer/src/keystore.rs
12
0.0
 0.0% applications/minotari_offline_signer/src/cli.rs

Coverage Regressions

Lines Coverage ∆ File
7
0.0
 0.0% applications/minotari_offline_signer/src/keystore.rs
4
80.33
 -0.83% comms/core/src/noise/socket.rs
2
80.15
 -0.48% comms/core/src/connection_manager/peer_connection.rs
2
83.12
 -0.32% comms/core/src/protocol/rpc/client/mod.rs
1
56.77
 -0.32% base_layer/core/src/base_node/state_machine_service/states/listening.rs
1
66.67
 -0.28% base_layer/core/src/mempool/sync_protocol/mod.rs
1
57.25
 -0.19% comms/dht/src/connectivity/mod.rs
Jobs
ID Job ID Ran Files Coverage
1 25304980873.1 702
60.97
 GitHub Action Run
Source Files on build 25304980873