roundup-tracker / roundup / 25301329220

75%

Build Type

push

github

Committed by rouilj

Commit Message

refactor: replace isinstance(x, type(Y)) with (x, <type>)

Early python2 construct:

  isinstance(var, type(""))

would test if var is an instance of string. Swap all the following:

  type({}) -> dict
  type(()) -> tuple
  type([]) -> list
  type("") -> str
  type('') -> str
  type(u'') -> str (also u"")
  type(1) -> int

This leads to a speedup when the two forms are compared with timeit.
It also modernizes the code.

(I kept isinstance(..., unicode) may replace at some point in
the future.

Coverage Stats

49 of 56 new or added lines in 13 files covered. (87.5%)

216 existing lines in 3 files now uncovered.

19177 of 25634 relevant lines covered (74.81%)

4.4 hits per line