saygoweb / anorm / 25294204668

97%

push

github

feat(lifecycle): allow listeners to call write() without re-invocation (#49)

* feat(lifecycle): allow listeners to call write() without re-invoking listener

A ChangeListener may now call DataMapper::write() — typically to persist a
follow-up record on a different table in response to a change. Nested writes
commit their SQL and refresh their own $_lastSnapshot, but do not re-invoke
the listener. Anorm assumes a single in-flight listener and suppresses
recursive notifications for any depth.

Previously, any write() call inside onWrite() raised
ReentrantWriteException, blocking the common "react to change by writing
elsewhere" pattern. The exception class is removed (3.1.x is unreleased,
so no BC obligation).

Implementation:

- DataMapper::write() drops the top-of-method re-entrancy throw.
- New $shouldNotify gate (= $hasListener && !$insideListener) controls
  the onWrite() dispatch, so nested writes still snapshot but skip the
  listener.
- The ReentrantWriteException catch arm is removed; only Throwable →
  error_log remains.

Tests in ChangeListenerTest replace the two re-entrancy assertions with
NestedWriteCommits (asserts both rows persist + nested snapshot is fresh)
and NestedWrite_DoesNotReinvokeListener (asserts callCount == 1).

* test(lifecycle): cover insideListener reset and diff null/array branches

Restores and extends the DataMapper test coverage that contracted when the
re-entrancy throw and its catch arm were removed. Coverage on src/DataMapper.php
goes from 183/189 (96.83%) to 185/189 (97.88%), exceeding the prior commit's
188/194 (96.91%).

New tests:

- testWrite_ListenerThrows_SubsequentWriteStillFiresListener: two consecutive
  writes through a listener that throws Throwable. Asserts callCount == 2,
  proving the finally block resets $insideListener even when the listener
  faults. Previously the throwing-listener test only did a single write, so
  this regression guard didn't exist.

- testWrite_AfterNestedWrite_OuterContinues... (continued)

6 of 6 new or added lines in 1 file covered. (100.0%)

1689 of 1996 relevant lines covered (84.62%)

17.36 hits per line