amazon-aurora / babelfish_extensions / 25292702641

78%

main: 77%

Build Type

push

github

Committed by manisha-deshpande

Commit Message

Address PR review comments - refactor cache code

Changes:
- Fix sysadmin check to use GetSessionUserId() for server-level role validation
- Add test cases for owner and sysadmin permissions on enable_antlr_parse_cache
- Move TDS/dialect checks into is_antlr_parse_cache_enabled_for_routine helper
- Refactor serialize_with_error_handling to simplify API (2 params instead of 4)
- Remove NULL checks after serialize calls since function now throws ERROR
- Initialize cache columns as NULL at function start, remove goto pattern
- Use goto cleanup pattern in pltsql_restore_antlr_parse_cache_result
- Simplify memory context handling in PG_CATCH blocks
- Reduce verbose function comments and remove debug logs

Task: BABEL-6037
Signed-off-by: Manisha Deshpande <mmdeshp@amazon.com>

Coverage Stats

25 of 29 new or added lines in 3 files covered. (86.21%)

2 existing lines in 1 file now uncovered.

53863 of 69896 relevant lines covered (77.06%)

400670.26 hits per line