wboayue / rust-ibapi / 25292026881

92%

push

github

test(news,scanner,wsh): builders + body-verifying test migration (#501)

* test(news,scanner,wsh): builders + body-verifying test migration

PR 6 of the test-builder rollout.

- Add request builders in src/testdata/builders/{news,scanner,wsh}.rs;
  contract_news/broad_tape_news reuse MarketDataRequestBuilder.
- Migrate sync/async tests to assert_request<B>(builder); move inline
  mod tests blocks to sibling _tests.rs files.
- Drop self-loop encoder tests in {news,scanner,wsh}/common/encoders.rs
  and the inline wsh/mod.rs::common_tests encoder asserts.
- Remove dead MessageBus/AsyncMessageBus::request_messages trait
  methods (only consumers were the migrated sync tests, which now
  call MessageBusStub::request_messages directly).

* test(builders): address PR review feedback

- Rename cancel_by_request_id_builder! to single_req_id_request_builder!.
  The macro is reused for non-cancel single-req_id requests
  (WshMetaDataRequest), mirroring production's encode_cancel_by_id!.
- HistoricalNewsRequestBuilder::default contract_id is now TEST_CONTRACT_ID
  (was 0, encoded as Some(0) in tests that forget to override).
- Drop dead _silence helper + unused request_message_count import in
  wsh/sync_tests.rs.
- Drop redundant path attribute in wsh/mod.rs common_tests declaration.

* test(news): apply /simplify cleanup

- Replace magic 8314 contract id with TEST_CONTRACT_ID; lets the
  builder use its default and drops a redundant .contract_id() setter.
- Extract repeated 84|9000|... news article response literal to a
  file-local NEWS_ARTICLE_RESPONSE const (5 callsites).

188 of 192 new or added lines in 3 files covered. (97.92%)

17388 of 19799 relevant lines covered (87.82%)

25.57 hits per line