Tatsh / re3-installer / #278
100%

DEFAULT BRANCH: master
Ran
Jobs 1
Files 13
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 100.0%. Remained the same
#278

push

travis-ci

Tatsh 
project: produce winarm64 package files on clang-aarch64 Windows

The earlier introduction of the clangarm64 build matrix leg shipped
the architecture only as a workflow-side label: `cpack_system:
winarm64` was passed to CMake as `-DCPACK_SYSTEM_NAME=winarm64`, but
`src/CMakeLists.txt` unconditionally rebuilt `__cpack_system_name`
from `CMAKE_SIZEOF_VOID_P` (8 → `win64`, else → `win32`),
overwriting the workflow value before `CPACK_PACKAGE_FILE_NAME` was
composed. CPack therefore wrote
`re3-installer-<version>-win64-Release.zip` even on the arm64 leg —
identical to the x86_64 ucrt64 and mingw64 outputs and visibly wrong
on the GitHub release page.

Honour an explicit `CPACK_SYSTEM_NAME` when it has been set on the
configure command line, and otherwise auto-detect arm64 by matching
`CMAKE_SYSTEM_PROCESSOR` against `aarch64|arm64|ARM64` (msys2's
lowercase token, generic `arm64`, and the Microsoft toolchain's
upper-case spelling). Both paths now select `winarm64` so a local
configure on a Windows-on-ARM host produces the right filename
without the workflow override, and the workflow override remains the
documented declarative knob.

CPack's NSIS generator also did not run on clangarm64 because
`actions/setup-msys2` defaults to `path-type: minimal`, which strips
the Windows `PATH` from the msys2 shell. The Chocolatey-installed
`makensis.exe` at `C:\Program Files (x86)\NSIS\makensis.exe` was
therefore invisible to `find_program(NSIS makensis)` and `cpack`
emitted only the ZIP archive, which then failed the
`softprops/action-gh-release@v3` step's
`fail_on_unmatched_files: true` glob for `re3-installer-*.exe`. Set
`path-type: inherit` for the clangarm64 leg only so the msys2 shell
sees the `$GITHUB_PATH` entry added by the prior Chocolatey install
step, while the other Windows legs continue to use
`path-type: minimal`.

Signed-off-by: Andrew Udvare <audvare@gmail.com>

383 of 383 relevant lines covered (100.0%)

7.7 hits per line

Jobs
ID Job ID Ran Files Coverage
1 #278.1 13
100.0
Source Files on build #278