TTRPG-Dev / ex_ttrpg_dev / 095103ca656aee2738c0e0d7390a04cecbbdff52-PR-111

86%

main: 87%

Build Type

Pull #111

github

Committed by QMalcolm

Commit Message

refactor(lib): remove excludes_from_cap from ProgressionConfig

The field was parsed and stored but never read by any library code.
It was intended to mark progression items (e.g. cantrips) as exempt from
the preparation cap, but the cap-exemption is already enforced by the
eligible-pool level filter: add_remove_eligible and toggle_field_eligible
both gate on level in 1..max_level, so level-0 items (cantrips) cannot
appear in item_ids and therefore cannot consume cap regardless.

A field that is parsed, stored, and has no observable effect on behaviour
is worse than not having it. If a future system needs explicit cap
exemption beyond what the level filter provides, it can be added then
with a real implementation.

Pull Request Pull Request #111: feat: spell preparation for dnd_5e_srd

Coverage Stats

371 of 434 new or added lines in 5 files covered. (85.48%)

2 existing lines in 2 files now uncovered.

1230 of 1428 relevant lines covered (86.13%)

9449.81 hits per line