wboayue / rust-ibapi / 25260398355

92%

Build Type

push

github

Committed by web-flow

Commit Message

test+fix: recover MockGateway-deletion coverage; fix async cancel deadlock (#482)

* test+fix: recover MockGateway-deletion coverage; fix async cancel deadlock

After PR 5 deleted client/{sync,async}/tests.rs, several files dropped
in coverage because the deleted MockGateway tests were the only callers
of certain trivial getters and MessageBus-trait impl methods.

Adds:
- src/client/{sync,async}_tests.rs: stubbed-Client tests covering
  is_connected, client_id, server_version, time_zone, connection_time,
  next_request_id, next_order_id, set_next_order_id, decoder_context,
  market_data, order, send_*, create_order_update_subscription,
  check_server_version (10 tests, sync+async).
- transport/sync/tests.rs: 5 tests against the real TcpMessageBus via
  the MessageBus trait — cancel_subscription, cancel_order_subscription,
  cancel_shared_subscription, send_message,
  create_order_update_subscription.
- transport/async_tests.rs: 5 mirroring tests on AsyncMessageBus.

Fixes (transport/async.rs):
- AsyncTcpMessageBus::cancel_subscription and cancel_order_subscription
  acquired a read guard, then awaited a write guard on the same RwLock
  while the read guard was still alive (Rust shadowing doesn't drop
  the prior binding). Self-deadlock on the same task. The new
  cancel_subscription test was the first caller exercising this path
  on the real bus and exposed the hang. Fix is a single write guard.

Coverage delta (cargo llvm-cov --all-features --summary-only):
  TOTAL                 region 82.65% -> 83.11%, line 87.21% -> 87.67%
  client/sync.rs        region 52.74% -> 60.27%, line 61.54% -> 70.19%
  client/async.rs       region 62.59% -> 70.07%, line 73.45% -> 81.42%
  transport/async.rs    region 44.26% -> 51.83%, line 46.14% -> 53.88%
  transport/sync/mod.rs region 59.02% -> 65.46%, line 62.06% -> 68.04%

Remaining gaps are concentrated in production-TCP paths (Client::connect,
AsyncTcpSocket, TcpMessageBus<TcpSocket> monomorphization) that cannot
... (continued)

Coverage Stats

53 of 63 new or added lines in 2 files covered. (84.13%)

1 existing line in 1 file now uncovered.

17085 of 19326 relevant lines covered (88.4%)

24.43 hits per line