25259185675

Committed 02 May 2026 06:47PM UTC coverage: 92.141% (-0.8%) from 92.955%

Build # 25259185675

Build Type

push

github

Committed by

web-flow

Commit Message

Fix the dynamic UI. (#23306)

In #23114 we upgraded to indicatif 0.18.4,
which included a fix to respect TERM, and 
display nothing if it's unset.

Since we did not pass TERM through pantsd, the
dynamic ui is now not shown. 

This change fixes that, and also pass NO_COLOR
through, since indicatif inspects it too.

Coverage Stats

88773 of 96345 relevant lines covered (92.14%)

3.83 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

70.59

/src/python/pants/backend/scala/resolve/artifact.py

# Copyright 2023 Pants project contributors (see CONTRIBUTORS.md).
# Licensed under the Apache License, Version 2.0 (see LICENSE).

from __future__ import annotations

from pants.backend.scala.target_types import ScalaArtifactFieldSet
from pants.engine.fs import EMPTY_DIGEST
from pants.engine.rules import collect_rules, implicitly, rule
from pants.engine.unions import UnionRule
from pants.jvm.compile import (
    ClasspathDependenciesRequest,
    ClasspathEntry,
    ClasspathEntryRequest,
    CompileResult,
    FallibleClasspathEntry,
    compile_classpath_entries,
)


class ScalaArtifactClasspathEntryRequest(ClasspathEntryRequest):
    field_sets = (ScalaArtifactFieldSet,)


@rule
async def scala_artifact_classpath(
    request: ScalaArtifactClasspathEntryRequest,
) -> FallibleClasspathEntry:
    fallible_entries = await compile_classpath_entries(
        **implicitly(ClasspathDependenciesRequest(request))
    )
    classpath_entries = fallible_entries.if_all_succeeded()
    if classpath_entries is None:
        return FallibleClasspathEntry(
            description=str(request.component),
            result=CompileResult.DEPENDENCY_FAILED,
            output=None,
            exit_code=1,
        )
    return FallibleClasspathEntry(
        description=str(request.component),
        result=CompileResult.SUCCEEDED,
        output=ClasspathEntry(EMPTY_DIGEST, dependencies=classpath_entries),
        exit_code=0,
    )


def rules():
    return [
        *collect_rules(),
        UnionRule(ClasspathEntryRequest, ScalaArtifactClasspathEntryRequest),
    ]

1	# Copyright 2023 Pants project contributors (see CONTRIBUTORS.md).
2	# Licensed under the Apache License, Version 2.0 (see LICENSE).
3
4	from __future__ import annotations	7✔
5
6	from pants.backend.scala.target_types import ScalaArtifactFieldSet	7✔
7	from pants.engine.fs import EMPTY_DIGEST	7✔
8	from pants.engine.rules import collect_rules, implicitly, rule	7✔
9	from pants.engine.unions import UnionRule	7✔
10	from pants.jvm.compile import (	7✔
11	ClasspathDependenciesRequest,
12	ClasspathEntry,
13	ClasspathEntryRequest,
14	CompileResult,
15	FallibleClasspathEntry,
16	compile_classpath_entries,
17	)
18
19
20	class ScalaArtifactClasspathEntryRequest(ClasspathEntryRequest):	7✔
21	field_sets = (ScalaArtifactFieldSet,)	7✔
22
23
24	@rule	7✔
25	async def scala_artifact_classpath(	7✔
26	request: ScalaArtifactClasspathEntryRequest,
27	) -> FallibleClasspathEntry:
28	fallible_entries = await compile_classpath_entries(	×
29	**implicitly(ClasspathDependenciesRequest(request))
30	)
31	classpath_entries = fallible_entries.if_all_succeeded()	×
32	if classpath_entries is None:	×
33	return FallibleClasspathEntry(	×
34	description=str(request.component),
35	result=CompileResult.DEPENDENCY_FAILED,
36	output=None,
37	exit_code=1,
38	)
39	return FallibleClasspathEntry(	×
40	description=str(request.component),
41	result=CompileResult.SUCCEEDED,
42	output=ClasspathEntry(EMPTY_DIGEST, dependencies=classpath_entries),
43	exit_code=0,
44	)
45
46
47	def rules():	7✔
48	return [	7✔
49	*collect_rules(),
50	UnionRule(ClasspathEntryRequest, ScalaArtifactClasspathEntryRequest),
51	]

pantsbuild / pants / 25259185675

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous