25259185675

Committed 02 May 2026 06:47PM UTC coverage: 92.141% (-0.8%) from 92.955%

Build # 25259185675

Build Type

push

github

Committed by

web-flow

Commit Message

Fix the dynamic UI. (#23306)

In #23114 we upgraded to indicatif 0.18.4,
which included a fix to respect TERM, and 
display nothing if it's unset.

Since we did not pass TERM through pantsd, the
dynamic ui is now not shown. 

This change fixes that, and also pass NO_COLOR
through, since indicatif inspects it too.

Coverage Stats

88773 of 96345 relevant lines covered (92.14%)

3.83 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

57.89

/src/python/pants/backend/java/goals/tailor.py

# Copyright 2021 Pants project contributors (see CONTRIBUTORS.md).
# Licensed under the Apache License, Version 2.0 (see LICENSE).

from __future__ import annotations

import os
from collections.abc import Iterable
from dataclasses import dataclass

from pants.backend.java.subsystems.javac import JavacSubsystem
from pants.backend.java.target_types import (
    JavaSourcesGeneratorTarget,
    JavaTestsGeneratorSourcesField,
    JunitTestsGeneratorTarget,
)
from pants.core.goals.tailor import (
    AllOwnedSources,
    PutativeTarget,
    PutativeTargets,
    PutativeTargetsRequest,
)
from pants.engine.intrinsics import path_globs_to_paths
from pants.engine.rules import collect_rules, rule
from pants.engine.target import Target
from pants.engine.unions import UnionRule
from pants.source.filespec import FilespecMatcher
from pants.util.dirutil import group_by_dir
from pants.util.logging import LogLevel


@dataclass(frozen=True)
class PutativeJavaTargetsRequest(PutativeTargetsRequest):
    pass


def classify_source_files(paths: Iterable[str]) -> dict[type[Target], set[str]]:
    """Returns a dict of target type -> files that belong to targets of that type."""
    tests_filespec_matcher = FilespecMatcher(JavaTestsGeneratorSourcesField.default, ())
    test_filenames = set(tests_filespec_matcher.matches([os.path.basename(path) for path in paths]))
    test_files = {path for path in paths if os.path.basename(path) in test_filenames}
    sources_files = set(paths) - test_files
    return {JunitTestsGeneratorTarget: test_files, JavaSourcesGeneratorTarget: sources_files}


@rule(level=LogLevel.DEBUG, desc="Determine candidate Java targets to create")
async def find_putative_targets(
    req: PutativeJavaTargetsRequest, all_owned_sources: AllOwnedSources, javac: JavacSubsystem
) -> PutativeTargets:
    putative_targets = []

    if javac.tailor_source_targets:
        all_java_files_globs = req.path_globs("*.java")
        all_java_files = await path_globs_to_paths(all_java_files_globs)
        unowned_java_files = set(all_java_files.files) - set(all_owned_sources)
        classified_unowned_java_files = classify_source_files(unowned_java_files)

        for tgt_type, paths in classified_unowned_java_files.items():
            for dirname, filenames in group_by_dir(paths).items():
                name = "tests" if tgt_type == JunitTestsGeneratorTarget else None
                putative_targets.append(
                    PutativeTarget.for_target_type(
                        tgt_type, path=dirname, name=name, triggering_sources=sorted(filenames)
                    )
                )

    return PutativeTargets(putative_targets)


def rules():
    return [
        *collect_rules(),
        UnionRule(PutativeTargetsRequest, PutativeJavaTargetsRequest),
    ]

1	# Copyright 2021 Pants project contributors (see CONTRIBUTORS.md).
2	# Licensed under the Apache License, Version 2.0 (see LICENSE).
3
4	from __future__ import annotations	2✔
5
6	import os	2✔
7	from collections.abc import Iterable	2✔
8	from dataclasses import dataclass	2✔
9
10	from pants.backend.java.subsystems.javac import JavacSubsystem	2✔
11	from pants.backend.java.target_types import (	2✔
12	JavaSourcesGeneratorTarget,
13	JavaTestsGeneratorSourcesField,
14	JunitTestsGeneratorTarget,
15	)
16	from pants.core.goals.tailor import (	2✔
17	AllOwnedSources,
18	PutativeTarget,
19	PutativeTargets,
20	PutativeTargetsRequest,
21	)
22	from pants.engine.intrinsics import path_globs_to_paths	2✔
23	from pants.engine.rules import collect_rules, rule	2✔
24	from pants.engine.target import Target	2✔
25	from pants.engine.unions import UnionRule	2✔
26	from pants.source.filespec import FilespecMatcher	2✔
27	from pants.util.dirutil import group_by_dir	2✔
28	from pants.util.logging import LogLevel	2✔
29
30
31	@dataclass(frozen=True)	2✔
32	class PutativeJavaTargetsRequest(PutativeTargetsRequest):	2✔
33	pass	2✔
34
35
36	def classify_source_files(paths: Iterable[str]) -> dict[type[Target], set[str]]:	2✔
37	"""Returns a dict of target type -> files that belong to targets of that type."""
38	tests_filespec_matcher = FilespecMatcher(JavaTestsGeneratorSourcesField.default, ())	×
39	test_filenames = set(tests_filespec_matcher.matches([os.path.basename(path) for path in paths]))	×
40	test_files = {path for path in paths if os.path.basename(path) in test_filenames}	×
41	sources_files = set(paths) - test_files	×
42	return {JunitTestsGeneratorTarget: test_files, JavaSourcesGeneratorTarget: sources_files}	×
43
44
45	@rule(level=LogLevel.DEBUG, desc="Determine candidate Java targets to create")	2✔
46	async def find_putative_targets(	2✔
47	req: PutativeJavaTargetsRequest, all_owned_sources: AllOwnedSources, javac: JavacSubsystem
48	) -> PutativeTargets:
49	putative_targets = []	×
50
51	if javac.tailor_source_targets:	×
52	all_java_files_globs = req.path_globs("*.java")	×
53	all_java_files = await path_globs_to_paths(all_java_files_globs)	×
54	unowned_java_files = set(all_java_files.files) - set(all_owned_sources)	×
55	classified_unowned_java_files = classify_source_files(unowned_java_files)	×
56
57	for tgt_type, paths in classified_unowned_java_files.items():	×
58	for dirname, filenames in group_by_dir(paths).items():	×
59	name = "tests" if tgt_type == JunitTestsGeneratorTarget else None	×
60	putative_targets.append(	×
61	PutativeTarget.for_target_type(
62	tgt_type, path=dirname, name=name, triggering_sources=sorted(filenames)
63	)
64	)
65
66	return PutativeTargets(putative_targets)	×
67
68
69	def rules():	2✔
70	return [	2✔
71	*collect_rules(),
72	UnionRule(PutativeTargetsRequest, PutativeJavaTargetsRequest),
73	]

pantsbuild / pants / 25259185675

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous