KarpelesLab / libwallet / 25243207308

24%

Build Type

push

github

Committed by MagicalTux

Commit Message

wltnet/bitcoinBalance: use modchain_lookupTxoBIP32 for xpub queries

modchain_assets returns balance:0 for some xpubs even when
spendable UTXOs exist at the standard m/0 + m/1 paths. Confirmed
on litecoin: xpub xpub661MyMw…cw has 0.1 LTC at m/0/0 (visible
via modchain_lookupTxoBIP32/m-0 → balance:0.1) but
modchain_assets/<xpub> reports balance:0 with txo:null even
though it correctly identifies lastI:0. End user sees a 0 balance
in the wallet despite holding funds.

Switch xpub balance queries to sum modchain_lookupTxoBIP32 over
the receive (m/0) and change (m/1) chains. Same RPC every other
libwallet bitcoin path already uses (signing pulls UTXOs from it
in wlttx/bitcoin.go, max-sendable in wlttx/maxsendable.go,
nextAddress in wltacct/btc_api.go) — so a wallet whose
maxSendable knows about funds but whose Asset:list doesn't is
no longer possible.

Plain-address fallback (used by view-only accounts with no xpub)
keeps modchain_assets — that endpoint works fine for single
addresses. Refactored into bitcoinXpubBalance and
bitcoinAddressBalance for clarity.

Amounts stay in satoshi via outscript.BtcAmount; sum is uint64
add so no float drift.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Coverage Stats

0 of 22 new or added lines in 1 file covered. (0.0%)

2 existing lines in 1 file now uncovered.

3073 of 14900 relevant lines covered (20.62%)

125.25 hits per line