thanos / ex_systolic / 40bbb6134d47060eb96d0bc34a8e64a4905d7d39-PR-29

94%

main: 98%

Build Type

Pull #29

github

Committed by thanos

Commit Message

All tests and Credo are now clean.
Changes relevant to your failures and warnings:
1. @impl warnings (compile --warnings-as-errors)
   - Added @impl true for coords/1:
     - ExSystolic.Space.Grid2D.coords/1
     - ExSystolic.ArrayTest.DummySpace.coords/1
   - mix compile --warnings-as-errors now passes with no warnings.
2. Trace ordering failure
   - Trace.record/2 was optimized to prepend events; internal trace.events order is now newest-first.
   - Updated TraceTest to assert on the logical order by reversing:
          trace2 = trace |> Trace.record(e0) |> Trace.record(e1)
     assert [0, 1] = trace2.events |> Enum.reverse() |> Enum.map(& &1.tick)

3. Boundary link coordinate tests
   - We standardized boundary coordinates to match row/col semantics:
     - West boundary: {row, -1} -> {row, 0}
     - North boundary: {-1, col} -> {0, col}
   - Updated ArrayTest expectations accordingly:
     - West:
              boundary  = Enum.find(array.links, &(&1.from == {{0, -1}, :east}))
       boundary1 = Enum.find(array.links, &(&1.from == {{1, -1}, :east}))
            - North:
              boundary0 = Enum.find(array.links, &(&1.from == {{-1, 0}, :south}))
       boundary1 = Enum.find(array.links, &(&1.from == {{-1, 1}, :south}))

4. Custom space boundary test
   - With the new coordinate convention, west boundaries have col == -1, north have row == -1.
   - Updated the custom-space test to detect any negative component:
          boundary =
       Enum.filter(array.links, fn link ->
         {r, c} = elem(link.from, 0)
         r < 0 or c < 0
       end)
     assert boundary != []

5. Credo refactor (nested depth warning)
   - Refactored Array.result_matrix/1 to use a helper to avoid deep nesting:
          def result_matrix(%{grid: grid, pes: pes}) do
       for r <- 0..(grid.rows - 1) do
         for c <- 0..(grid.cols - 1) do
           cell_state(pes, {r, c})
         end
       end
     end
     defp cell_state(pes, coord) do
       case Map.get(... (continued)

Pull Request Pull Request #29: V0.1.1/pahse1.5 pluggable space topology

Coverage Stats

92 of 96 new or added lines in 7 files covered. (95.83%)

1 existing line in 1 file now uncovered.

222 of 235 relevant lines covered (94.47%)

2175.5 hits per line