rm-hull / next-departures-api / 25230342317

28%

push

github

feat: handle SIRI rate limits and add route tests (#8)

*   Implemented handling for SIRI API "Usage limits exceeded" errors by
    returning **429 Too Many Requests**.
*   Added `Retry-After` and `X-RateLimit-Reset` headers calculated based
    on the duration until midnight.
*   Refactored `SiriClient` into an interface to facilitate mocking and
    improved testability.
*   Introduced comprehensive unit tests for the `NextDepartures` route
    covering success, rate-limiting, and error scenarios.

```mermaid
sequenceDiagram
    participant User
    participant Route as NextDepartures Route
    participant Client as SiriClient (Mock/Impl)
    User->>Route: Request departures for stopId
    Route->>Client: GetStopMonitoring(stopId)
    alt Rate Limited
        Client-->>Route: 403 Forbidden (Usage limits exceeded)
        Route-->>User: 429 Too Many Requests + Retry-After headers
    else Success
        Client-->>Route: 200 OK + Siri Data
        Route-->>User: 200 OK + Formatted Results
    end
```

---------

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

10 of 13 new or added lines in 2 files covered. (76.92%)

213 of 965 relevant lines covered (22.07%)

0.24 hits per line