stacklok / toolhive / 25218379205

65%

Build Type

push

github

Committed by web-flow

Commit Message

Allow standalone Redis in auth server storage (#4994)

* Allow standalone Redis in auth server: update validateConfig

Add Addr field to RedisConfig for standalone mode (e.g., GCP Memorystore,
AWS ElastiCache), making it mutually exclusive with SentinelConfig.
Update validateConfig to enforce the mutual exclusion and require exactly
one connection mode. Update NewRedisStorage to branch between
redis.NewClient (standalone) and redis.NewFailoverClient (sentinel).

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* Allow standalone Redis in auth server: add Addr to RunConfig and update converter

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* Allow standalone Redis in auth server: update CRD RedisStorageConfig

Add an Addr field for standalone Redis mode and make SentinelConfig
optional. A CEL XValidation rule enforces that exactly one of addr
(standalone) or sentinelConfig (Sentinel) is set. Regenerate deepcopy,
CRD manifests, and API reference docs.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* Allow standalone Redis in auth server: update operator buildStorageRunConfig

Replace the Sentinel-only requirement with support for either a standalone
addr or a SentinelConfig, matching the new RedisStorageConfig.Addr field
added to the CRD in earlier tasks.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* Fix review issues in standalone Redis implementation

- Fix CEL XValidation rule Unicode curly quote bug in RedisStorageConfig
  (replaced U+201D right double quotation mark with ASCII single quotes)
- Add mutual exclusivity guard when both addr and sentinelConfig are set
  in buildStorageRunConfig
- Add test case covering the addr+sentinelConfig conflict error path
- Update RedisStorage doc comment to describe both standalone and Sentinel modes
- Use t.Cleanup instead of defer in withRedisStorage parallel test helper
- Use non-default ACL username in TestNewRedisStorage_Standalone_WithMiniredis
- Regenera... (continued)

Coverage Stats

120 of 131 new or added lines in 3 files covered. (91.6%)

15 existing lines in 5 files now uncovered.

61855 of 95862 relevant lines covered (64.53%)

59.65 hits per line