supabase / wrappers / 25217488007

82%

Build Type

push

github

Committed by web-flow

Commit Message

feat: add aggregate pushdown support (COUNT/SUM/AVG/MIN/MAX) (#586)

* feat: add aggregate pushdown support (COUNT/SUM/AVG/MIN/MAX)

Based on PR #549 by JohnCari with critical fix: aggregates and group_by
are now stored in FdwState and passed through output_rel->fdw_private
to the executor. Previously fdw_private was null, so extracted aggregates
were silently discarded.

Changes:
- Add AggregateKind enum, Aggregate struct with deparse() methods
- Add FDW trait methods: supported_aggregates(), supports_group_by(),
  get_aggregate_rel_size(), begin_aggregate_scan()
- Add GetForeignUpperPaths callback in new upper.rs module
- Add aggregates/group_by fields to FdwState in scan.rs
- begin_foreign_scan detects aggregate path and calls begin_aggregate_scan
- EXPLAIN output includes aggregate info when present
- PG version compat: PG13-PG18 (disabled_nodes, fdw_restrictinfo)

* fix: address CodeRabbit review — validate aggregates and GROUP BY

1. Reject pushdown when SUM/AVG/MIN/MAX has no simple column reference
   (e.g. SUM(a+b)) to avoid generating invalid SQL like SUM(*)
2. Abort pushdown when any GROUP BY item is not a plain column reference
   to prevent incomplete GROUP BY clauses
3. Rebuild state.tgts for aggregate paths to reflect the actual output
   shape (group_by columns + aggregate result columns), preventing
   ERRCODE_FDW_INVALID_COLUMN_NUMBER from the executor

* fix: guard upper module import with PG feature cfg

The upper module is conditionally compiled with pg13-pg18 feature flags,
but fdw_routine() imported it unconditionally, causing build failures
without PG features. Wrap the import and GetForeignUpperPaths assignment
with the same cfg guard.

* fix: address CodeRabbit round 2 — aggfilter, aggtype, default warning

1. Reject pushdown for aggregates with FILTER clause (aggfilter check)
2. Add type_oid field to Aggregate struct, populated from Aggref::aggtype
   instead of inferring from the input column type
3. Default begin_aggregate... (continued)

Coverage Stats

655 of 752 new or added lines in 6 files covered. (87.1%)

3 existing lines in 2 files now uncovered.

9020 of 11165 relevant lines covered (80.79%)

64.61 hits per line