jqueguiner / num2words2 / 25215226920

95%

master: 94%

Build Type

push

github

Committed by web-flow

Commit Message

fix(tr): natural-precision floats, ordinal_num apostrophe, Decimal input (#111)

Three correctness fixes for Turkish that made it into the same patch
because they're tangled in the same to_cardinal/to_ordinal_num path
and the existing tests had been encoding the buggy outputs.

1. Float reading at natural precision (savoirfairelinux/num2words#487)
   Previously num2words(0.1, lang='tr') padded to '0.10' and read it as
   "sıfır virgül on" (zero point ten). The natural Turkish reading is
   "sıfır virgül bir" (zero point one). The library was already doing
   digit-by-digit reading for 0.01 → "sıfır bir" — only single-digit
   fractions were over-padded. We now use the input's natural precision
   from Decimal(str(value)).as_tuple().exponent when self.precision is
   at the language default. Two-digit fractions (0.25 → "yirmi beş"),
   leading-zero fractions (0.01, 0.05), and explicit precision=
   overrides are all preserved.

2. to_ordinal_num apostrophe + correct suffix (savoirfairelinux/num2words#128)
   Standard Turkish (TDK) writes ordinals as digit + apostrophe + suffix
   matching the cardinal's vowel harmony AND its ending. Cardinals
   ending in a vowel take a 3-char suffix ("nci/ncı/ncu/ncü"); cardinals
   ending in a consonant take a 4-char suffix ("inci/ıncı/uncu/üncü").
   The previous implementation just took to_ordinal()[-4:] and dropped
   the apostrophe, producing "5inci" instead of "5'inci" and "2inci"
   instead of "2'nci". Now we recover the suffix by stripping the
   cardinal off the ordinal — robust under all vowel-harmony cases.

3. verify_cardinal accepts Decimal input (chained from #1)
   The historical `if not float(value) == value` check returned False
   for Decimal('0.1') because float(Decimal('0.1')) ≈ 0.1 ≠ Decimal('0.1')
   under IEEE 754. _to_cardinal_impl then short-circuited to "" instead
   of routing to to_cardinal_float. Removed that misnamed gate; we now
   only reject inputs that don't survive a float() probe.

... (continued)

Coverage Stats

7941 of 8696 branches covered (91.32%)

Branch coverage included in aggregate %.

211 of 214 new or added lines in 4 files covered. (98.6%)

1 existing line in 1 file now uncovered.

41870 of 43582 relevant lines covered (96.07%)

5.76 hits per line