KarpelesLab / goro / 25206536277

13%

push

github

perf: cut allocs in operatorMath, add VoidRunnable for postfix ++/--

Two narrow optimizations in the hot expression path, identified by
profiling BenchmarkArithmetic.

1. operatorMath returned a freshly-allocated phpv.ZVal that was the
   .ZVal() of a phpv.Val interface intermediate. Boxing an int64 into
   the Val interface allocated 8 bytes on every arithmetic op even when
   the inner number was a small cached value. Restructure so each
   ZtInt/ZtFloat case directly returns the appropriate ZInt.ZVal()
   or ZFloat.ZVal() and skips the interface intermediate.

2. Add a phpv.VoidRunnable interface with RunVoid(Context) error and
   implement it on runOperator for postfix ++/--. RunVoid skips the
   `orig := a.Dup()` snapshot whose only purpose is feeding the
   throw-away return value when the increment is in a result-discard
   position. Wire the for-loop's third clause (r.each) to prefer
   RunVoid when the runnable supports it.

BenchmarkArithmetic     85.0M ns → 49.1M ns   (-42%)
                       1018k allocs → 619k    (-39%)
BenchmarkFunctionCalls  32.5M ns → 16.2M ns   (-50%)
                        358k allocs → 318k    (-11%)
BenchmarkArrayOps       13.3M ns → 11.0M ns   (-17%)
                        178k allocs → 138k    (-22%)
BenchmarkStringConcat   17.7M ns → 14.0M ns   (-21%)
                        158k allocs → 100k    (-37%)
BenchmarkFibonacci      26.5M ns → 24.0M ns   (-9%)

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

0 of 74 new or added lines in 2 files covered. (0.0%)

2189 of 112047 relevant lines covered (1.95%)

70.3 hits per line