umputun / revdiff / 25206098825

90%

master: 90%

push

github

fix(review-loop): final cleanup pass — addressed 2 minor findings

- [minor] app/ui/annotnav.go:25 — handleAnnotNav was O(N²) (len(flat) outer
  retries × pickAdjacentAnnotation O(N) inner). Refactored to compute the
  starting flat-list index once via startingFlatIndex, then walk indexes
  directly with ±1 step. Each candidate is examined at most once → O(N)
  worst case even when every annotation is non-jumpable.

- [minor] app/ui/annotnav.go:81 — currentAnnotKey mapped ALL ChangeDivider
  rows to line=-1, which is correct for leading dividers but causes
  middle/trailing dividers (reachable via mouse-click) to short-circuit
  forward } back to the file-level/first same-file annotation. Fixed by
  walking back to the nearest preceding non-divider line via
  dividerAnnotKey and inheriting its position; only leading dividers (no
  prior non-divider line) fall back to line=-1.

Tests added for middle/trailing/consecutive-divider cases at both unit
and integration level. The pickAdjacentAnnotation table tests now run
through a test-only wrapper around startingFlatIndex so the picking
algorithm documentation is preserved.

21 of 21 new or added lines in 1 file covered. (100.0%)

9443 of 10529 relevant lines covered (89.69%)

514.57 hits per line