kaidokert / rm32 / 25204210268

63%

main: 63%

Build Type

Pull #29

github

Committed by kaidokert

Commit Message

Fix ramp profile: use average_interval not duty.last for RPM threshold

Pre-existing bug: ramp_limit used self.last > 500 (duty cycle) to
select between low/high RPM ramp rates. C code uses average_interval
> 500 (timing-based RPM indicator). The duty-based check could select
the wrong ramp rate when duty and RPM diverge.

Compute average_interval from e_com_time in the ISR and pass it to
ramp_limit. Add 4 unit tests for ramp profile selection that would
have caught this bug. Also fix compute_setpoint docstring.

Pull Request Pull Request #29: Make DutyState fields fully private, extract ISR logic into methods

Coverage Stats

124 of 145 new or added lines in 2 files covered. (85.52%)

36 existing lines in 1 file now uncovered.

3489 of 5618 relevant lines covered (62.1%)

776.47 hits per line