iotaledger / iota / 25198063136

push

github

feat: replace `Argument` with SDK version (#10331) (#11393)

This PR is part of the ongoing effort to consolidate blockchain types in
the
canonical `iota-rust-sdk`. Types that are needed by both clients/SDK
consumers
and the node should live in `iota-rust-sdk` and be imported from there,
instead
of being defined twice (once in `iota-types`, once in the SDK).

This PR replaces `Argument` (previously defined in `iota-types`) with
the
SDK version from `iota-sdk-types`. To keep the diff small and avoid
touching
every call site, the SDK type is re-exported from `iota-types` under the
original name `Argument`, so most existing imports continue to work
unchanged.

## Notable changes

- The `Argument::GasCoin` variant is renamed to `Argument::Gas` to match
the
  SDK definition. Call sites are updated accordingly.
- The local `Display` impl is removed in favor of the SDK's. This
changes the
textual representation of the gas argument from `GasCoin` to `Gas`
(visible
  in PTB snapshot tests and CLI output).
- The bidirectional `From`/`Into` conversions between the local and SDK
`Argument` types are removed since both sides are now the same type,
which
simplifies `iota_sdk_types_conversions.rs` for `Command` significantly.
- `scripts/update_sdk_types_rev.sh` is made cross-platform (works on
macOS
too): replaces GNU-only `sed -i` and `grep -oP` with portable
equivalents,
and falls back to a background-process timeout when neither `timeout`
nor
  `gtimeout` is available.

### Release Notes

- [ ] Protocol:
- [ ] Nodes (Validators and Full nodes):
- [ ] Indexer:
- [ ] JSON-RPC:
- [ ] GraphQL:
- [x] CLI: The `Argument::GasCoin` PTB argument now displays as `Gas`
instead
  of `GasCoin` in CLI output and PTB snapshots.
- [x] Rust SDK: `iota_types::transaction::Argument` is now a re-export
of
`iota_sdk_types::Argument`. The `GasCoin` variant has been renamed to
`Gas`
  to match the SDK definition.
- [ ] gRPC:

26 of 47 new or added lines in 15 files covered. (55.32%)

156122 of 247302 relevant lines covered (63.13%)

451149.13 hits per line