dangernoodle-io / TaipanMiner / 25193487965

90%

push

github

refactor(webui): hoist pure helpers to lib/, migrate confirm() to ConfirmDialog, clean up warnings (TA-309 phase 1) (#283)

First slice of the Svelte audit. No behavior changes.

## lib extraction

- new lib/coinbase.ts holds nbitsToDifficulty, coinbaseTag, coinbaseHeight,
  coinbaseTotalReward, coinbasePayoutSpk, segwitAddress + bech32 helpers
  — all moved out of Pool.svelte (~150 inline lines).
- lib/fmt.ts gains fmtNetDiff, fmtDiff, fmtBtc, fmtNtimeAge, truncAddr,
  truncWallet, fmtPct, fmtGhsNum, fmtGhsUnit, rssiBars.
- History.svelte fmtHashrate aliased to fmtHashGhs (was identical).
- Update.svelte fmtSize aliased to fmtBytes (was identical).
- PoolRow.svelte's inline BIP34 parse in decodeStatus replaced with
  coinbaseHeight() call from lib/coinbase.ts.

## confirm() migration

- Pool.svelte handleRemove no longer uses window.confirm(); routes
  through ConfirmDialog instead. Dynamic message based on slot.
- Zero native confirm/alert/prompt remain in webui/miner/src.

## svelte-check warnings: 13 → 0

- ConfirmDialog: removed autofocus (a11y).
- Pool.svelte: removed dead CSS (.card.pending, .loading, .error,
  .hostname, .host-row family).
- Diagnostics.svelte: removed dead CSS (.hint, code, input[type=text]).
- Settings.svelte: removed dead CSS (.toggle).

## Deferred to phase 2

CSS primitives consolidation (.conn-dot, .spinner, .status-pill,
.card-footer, .btn.outline.danger, .modal-*, .section-head into
ui-kit utilities.css) and component splits (Hero → RejectStrip +
RollingRates, Diagnostics SSE → lib/sse.ts, AlertBanner store
decoupling, Pool switching overlay component) ship as a follow-up
PR — bigger surface area, want to verify phase 1 first.

Build clean, 0 svelte-check warnings, 71 SPA tests + 460 host tests
pass.

Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>

664 of 782 branches covered (84.91%)

Branch coverage included in aggregate %.

1488 of 1511 relevant lines covered (98.48%)

275324.85 hits per line