xolox / python-npm-accel / 8

91%

Pull #1

travis-ci

Fix calling node/nodejs binary in `nodejs_version`

- The primary nodejs executable being called
  `nodejs` is a Debian-ism, and is not compatible
  with upstream nodejs and non-Debian distros,
  because upstream just calls the binary `node`.

- This makes the `node_version` method fail
  on non-Debian systems, where `nodejs` is
  actually called `node` instead.

- Instead of just executing the `nodejs` command,
  we now first search for it in `PATH`, using
  `distutils.spawn.find_executable`, which
  should be available on Python 2.4+.

- When no node executable is found,
  a NodeBinaryNotFoundError is now raised.

- If one of the node executables is found,
  we return the result of `node/nodejs --version`
  as before.

9 of 9 new or added lines in 2 files covered. (100.0%)

240 of 257 relevant lines covered (93.39%)

3.74 hits per line