bitcoindevkit / rust-esplora-client / 25181910660

88%

Build Type

push

github

Committed by luisschwab

Commit Message

Merge bitcoindevkit/rust-esplora-client#137: refactor(client)!: use `bitreq` for both `BlockingClient` and `AsyncClient`

<a class=hub.com/bitcoindevkit/rust-esplora-client/commit/2ec119bb97d509d6a6111a8c05ea22b6537e4c3a">2ec119bb9<a href="https://github.com/bitcoindevkit/rust-esplora-client/commit/629cce5665a0b8bdc38d3bfe2af5315e385d1928"> refactor(async): centralize `Request` building (Leonardo Lima)
<a class="double-link" href="https://github.com/bitcoindevkit/rust-esplora-client/commit/121467b34706a5fab2fc9cc89dd8e85f52e17790">121467b34</a><a href="https://github.com/bitcoindevkit/rust-esplora-client/commit/629cce5665a0b8bdc38d3bfe2af5315e385d1928"> refactor(blocking): improve some duplicated code (Leonardo Lima)
</a><a class="double-link" href="https://github.com/bitcoindevkit/rust-esplora-client/commit/746354fb9bf11fe42523542e047ac587780be8ba">746354fb9</a><a href="https://github.com/bitcoindevkit/rust-esplora-client/commit/629cce5665a0b8bdc38d3bfe2af5315e385d1928"> chore(ci): remove pinned MSRV dependencies (Leonardo Lima)
</a><a class="double-link" href="https://github.com/bitcoindevkit/rust-esplora-client/commit/f6b35e32d545c2af3739ab5d89d5d44fdeead4fc">f6b35e32d</a><a href="https://github.com/bitcoindevkit/rust-esplora-client/commit/629cce5665a0b8bdc38d3bfe2af5315e385d1928"> refactor(client)!: use `bitreq` for `AsyncClient` (Leonardo Lima)
</a><a class="double-link" href="https://github.com/bitcoindevkit/rust-esplora-client/commit/01c6e4dba8b72cbf73c9509f02255dd7474590f7">01c6e4dba</a><a href="https://github.com/bitcoindevkit/rust-esplora-client/commit/629cce5665a0b8bdc38d3bfe2af5315e385d1928"> refactor(client)!: use `bitreq` for `BlockingClient` (Leonardo Lima)
</a><a class="double-link" href="https://github.com/bitcoindevkit/rust-esplora-client/commit/dfea19bcd115f491a36c82731e39db061208e88b">dfea19bcd</a> chore(deps): bump `electrsd` to `0.38.0` (Leonardo Lima)

Pull request description:

  Closes #136
  Closes #183
  Closes #184
  Closes #185

  ### Description

  The PR remove the usage of both `minreq` and `reqwest`, relying on only in `bitreq` as the HTTP client for both `BlockingClient` and `AsyncClient`.

  It also does some minimal refactor in `BlockingClient` to remove some of the duplicated code, more refactoring and organization could be done in a follow-up.

  ### Notes to the reviewers

  Let me know in the comments if you see any improvements feature-wise, or on the usage of `bitreq` API.

  ### Changelog notice

  TBD

  ### Checklists

  #### All Submissions:

  * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)

  #### New Features:

  * [x] I've added tests for the new feature
  * [x] I've added docs for the new feature

ACKs for top commit:
  luisschwab:
    tACK 2ec119bb97d509d6a6111a8c05ea22b6537e4c3a

Tree-SHA512: 50c585c258d8985c684497257447c3bd844

Coverage Stats

136 of 191 new or added lines in 3 files covered. (71.2%)

7 existing lines in 2 files now uncovered.

1496 of 1670 relevant lines covered (89.58%)

12.2 hits per line