umputun / ralphex / 25181837650

83%

Build Type

push

github

Committed by web-flow

Commit Message

feat: add --branch flag to override worktree/branch name (#315)

* feat: add --branch flag to override worktree/branch name

Replaces fragile auto-detection from plan filenames when plan files use
generic names (tasks.md, plan.md) or spec-driven directory layouts where
ExtractBranchName produces wrong or unstable results.

* fix: reduce cyclomatic complexity and add nolint explanation

Extract resolveWorktreePlanFile helper from runWithWorktree to bring
cyclomatic complexity within the linter limit; add explanation to the
nolint:errcheck directive in service_test.go.

* fix: validate branchOverride to prevent path traversal in worktree creation

Reject absolute paths and values that escape .ralphex/worktrees/ when
--branch override is used as a filesystem path element.

* Revert "fix: validate branchOverride to prevent path traversal in worktree creation"

This reverts commit f5cd33630.

* fix: address review feedback on --branch flag implementation

- add EffectiveBranchName() method on Service, eliminating the 4-site
  override-or-extract duplication (preparePlanBranch, CreateWorktreeForPlan,
  runWithWorktree progress logger, CommitPlanFile)
- thread BranchOverride into runPlanMode so --plan --branch=foo no longer
  silently drops the override
- CommitPlanFile now uses current git branch for the commit message instead
  of re-deriving from the plan filename, fixing the mismatch when --branch
  differs from the filename slug
- move branch-override subtests from TestService_RemoveWorktree into
  TestService_CreateWorktreeForPlan and TestService_CreateBranchForPlan
- fix gofmt struct alignment on executePlanRequest.BranchOverride

Coverage Stats

15 of 66 new or added lines in 2 files covered. (22.73%)

5 existing lines in 3 files now uncovered.

6825 of 8261 relevant lines covered (82.62%)

220.52 hits per line