jtblin / kube2iam / 167

58%

master: 8%

push

circleci

test: add unit, integration, and E2E test infrastructure (closes #5)

Coverage grew from ~7.7% to 55% across all packages. All tests pass
with no changes to production behavior.

## Refactoring for testability

- iam/iam.go: extract IMDSClient interface over *imds.Client with
  GetMetadata and GetIAMInfo methods; add IMDS field to iam.Client
  for dependency injection; refactor GetInstanceId and doHealthcheck
  to use the injected client
- iam/arn.go: add GetBaseArnWithClient(IMDSClient) accepting a mock;
  GetBaseArn() delegates to it with the real client
- server: add iam and roleMapper fields to *Server so HTTP handlers
  can receive injected mocks without interface proliferation

## Unit tests

iam/iam_test.go (+340 lines):
  - AssumeRole: cache hit, external ID, STS error, region validation
  - GetInstanceId: success and IMDS error paths
  - GetHash, sessionName, GetEndpointFromRegion, GetIAMCode helpers

iam/arn_test.go (+130 lines):
  - IsValidBaseARN, RoleARN, GetBaseArnWithClient with mock IMDS

k8s/k8s_test.go (new, +155 lines):
  - PodByIP, NamespaceByName, ListPodIPs/Namespaces
  - Duplicate IP handling (hostNetwork pods)
  - Uses fake client-go Indexers; no live cluster required

server/server_test.go (new, +350 lines):
  - parseRemoteAddr (table-driven, 6 cases)
  - healthHandler: healthy and unhealthy (HealthcheckFailReason set)
  - securityCredentialsHandler: role found, cross-account ARN, pod
    not found
  - roleHandler: match, mismatch (403), mapping error (404), STS
    error (500)
  - reverseProxyHandler: IMDSv2 PUT token, IMDSv2 GET with token,
    standard GET (XFF header behavior)
  - debugStoreHandler, doHealthcheck success/failure, NewServer
    defaults

mappings/mapper_test.go (+115 lines):
  - GetRoleMapping: no annotation + no default (error), with default
    role, pod not found
  - GetExternalIDMapping: with and without annotation
  - DumpDebugInfo: key presence and role-by-IP value verification
  - Extend storeMock to... (continued)

9 of 26 new or added lines in 2 files covered. (34.62%)

533 of 919 relevant lines covered (58.0%)

3.1 hits per line