stacklok / toolhive-cloud-ui / 25164594282

78%

push

github

fix: hardcode OIDC_PROVIDER_ID to oidc (#497)

* Hardcode OIDC_PROVIDER_ID to "oidc"

The providerId is Better Auth's internal identifier used in the
OAuth2 callback URL path (e.g., /api/auth/oauth2/callback/oidc).
It is not related to any specific identity provider (Okta, Auth0,
etc.) and has no reason to vary between deployments.

Hardcoding it to "oidc" simplifies configuration and makes the
redirect URI predictable for all customers, removing one env var
that was confusing and unnecessary.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* Use static "Sign in" button text instead of provider name

The sign-in button was deriving its text from OIDC_PROVIDER_ID (showing
"Oidc" after hardcoding). Replace with static "Sign in" text and remove
the Okta icon, matching the enterprise implementation.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* Fix hono and postcss transitive vulnerabilities via pnpm overrides

- hono: ^4.12.12 → >=4.12.14 (GHSA-458j-xx4x-4375, HTML injection in JSX SSR)
- postcss: added >=8.5.10 override (GHSA-qx2v-qp2m-jg93, XSS via </style>)

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* Remove dead OktaIcon component

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* Fix E2E fixture sign-in button selector

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* Add explanatory comment for hardcoded OIDC_PROVIDER_ID

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

241 of 319 branches covered (75.55%)

1 of 1 new or added line in 1 file covered. (100.0%)

465 of 593 relevant lines covered (78.41%)

13.33 hits per line