maximunited / imou_life / 25138360867

90%

push

github

fix: improve config flow UI - conditional URL field and better labels (#13)

Fixed multiple UI issues in the config flow login step:

**Bug Fix:**
- URL field no longer shows for preset servers (only appears when "Custom" is selected)
- Eliminates the confusing behavior where URL didn't update when switching servers
- URL field is now only visible and editable when user selects "Custom" server

**Enhancements:**
1. **Conditional URL Field**
   - For preset servers (Global, Frankfurt, Singapore, Virginia, China): URL field hidden
   - For "Custom" server: URL field appears as required field for manual entry
   - Cleaner, less confusing UI - users only see what they need

2. **Improved "Enable Discovery" Label and Description**
   - Changed from "Discover registered devices" to "Enable Device Discovery"
   - Added helpful description: "Automatically discover all devices registered to your Imou account. Disable to manually enter a specific device ID instead."
   - Makes it clear what this option does and when to disable it

3. **Updated Field Labels**
   - "API Base URL" → "Custom API URL" (only shown for custom server)
   - More accurate label since it's only for custom servers

**Technical Changes:**
- Config flow schema now built conditionally based on selected server
- URL field only added to schema when selected_server == "custom"
- Removed unused DEFAULT_API_URL import
- Updated all 8 translation files with new labels and descriptions

**User Experience Before:**
- User selects "Frankfurt" → URL shows old value (doesn't update)
- Confusing whether URL is used or ignored
- Unclear what "enable_discover" means

**User Experience After:**
- User selects "Frankfurt" → no URL field shown (clean)
- User selects "Custom" → URL field appears for manual entry
- Clear description explains discovery vs manual device entry
- Intuitive and straightforward

**Tests:**
- All 229 unit tests passing
- Pre-commit hooks passing
- Config flow tests verify both preset ... (continued)

0 of 7 new or added lines in 1 file covered. (0.0%)

917 of 1288 relevant lines covered (71.2%)

2.14 hits per line