dangernoodle-io / breadboard / 25121582925

100%

push

github

fix(bb_ota_push): use OTA_RECV_BUF_SIZE not sizeof(buf) after heap migration (#150)

PR #147 (B1-118) moved the OTA recv buffer from stack-allocated
`char buf[OTA_RECV_BUF_SIZE]` to heap-allocated `char *buf =
malloc(OTA_RECV_BUF_SIZE)` to free up httpd task stack. The recv
size argument still used `sizeof(buf)` which silently became
`sizeof(char *)` (4 or 8 bytes) instead of 1024.

Result: each httpd_req_recv() requested only 4 bytes per call.
Kernel TCP buffer filled, TCP window stalled, httpd's
recv_wait_timeout fired, OTA push aborted around 80s with
`exit code 56` on curl. Reproduced on bitaxe-403 and tdongle-s3.

Fix: replace `sizeof(buf)` with the `OTA_RECV_BUF_SIZE` define.
Validated end-to-end: bitaxe-403 OTA push 1.18 MB in 8.1s,
tdongle-s3 OTA push 1.17 MB in 17.9s — both back to expected
throughput.

330 of 330 branches covered (100.0%)

Branch coverage included in aggregate %.

521 of 521 relevant lines covered (100.0%)

482.79 hits per line