stephenafamo / bob / 25060927406

44%

main: 47%

Pull #661

github

fix(pgx): return ErrTxClosed from Commit instead of swallowing it

When a transaction is already closed (e.g., rolled back by the context
expiry goroutine), Commit() should return pgx.ErrTxClosed to inform
the caller that the commit did not succeed.

Swallowing this error makes the client believe the commit succeeded
when it actually failed, which can lead to silent data loss.

This aligns with Go stdlib behavior where sql.Tx.Commit() returns
ErrTxDone if the transaction is already closed.

Rollback() continues to swallow ErrTxClosed to support the idiomatic
defer tx.Rollback() pattern.

Fixes #640

0 of 1 new or added line in 1 file covered. (0.0%)

10451 of 23861 relevant lines covered (43.8%)

590.97 hits per line