25097947148
71%

Ran 29 Apr 2026 08:16AM UTC

Jobs 1

Files 705

Run time 2min

Badge

Embed ▾

Committed 29 Apr 2026 08:10AM UTC coverage: 63.913% (-0.03%) from 63.939%

Build # 25097947148

Build Type

push

github

Committed by

web-flow

Commit Message

Wire MCPRemoteProxy resourceOverrides.proxyDeployment.imagePullSecrets (#5103)

The MCPRemoteProxy spec accepts spec.resourceOverrides.proxyDeployment
.imagePullSecrets via the ResourceOverrides type shared with MCPServer,
but the MCPRemoteProxy controller never read it. Users configuring
private-registry credentials silently got no effect: the proxy-runner
Deployment and ServiceAccount were created with no image pull secrets
and image pulls failed against authenticated registries.

Mirror the MCPServer wiring: extract ImagePullSecrets from
ResourceOverrides via a small helper and apply it to both the
proxy-runner ServiceAccount (through rbac.EnsureRBACResourcesParams)
and the Deployment pod spec.

Add TestMCPRemoteProxyEnsureRBACResources_ImagePullSecrets covering
both surfaces.

Fixes #5099

Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Coverage Stats

60435 of 94558 relevant lines covered (63.91%)

57.68 hits per line

Coverage Regressions

Lines	Coverage	∆	File
12	75.09	-4.33%	pkg/client/config.go
12	67.9	-14.81%	pkg/client/discovery.go
8	23.56	-4.6%	pkg/client/manager.go
6	51.22	-0.56%	pkg/workloads/manager.go
3	71.85	-1.11%	pkg/ignore/processor.go

Jobs

ID	Job ID	Ran	Files	Coverage
1	25097947148.1	29 Apr 2026 08:16AM UTC	705	63.91	GitHub Action Run

stacklok / toolhive / 25097947148
71%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Coverage Regressions

Jobs

Source Files on build 25097947148

stacklok / toolhive / 25097947148 71%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Coverage Regressions

Jobs

Source Files on build 25097947148

stacklok / toolhive / 25097947148
71%

README BADGES
x