stacklok / toolhive / 25097947148

66%

Build Type

push

github

Committed by web-flow

Commit Message

Wire MCPRemoteProxy resourceOverrides.proxyDeployment.imagePullSecrets (#5103)

The MCPRemoteProxy spec accepts spec.resourceOverrides.proxyDeployment
.imagePullSecrets via the ResourceOverrides type shared with MCPServer,
but the MCPRemoteProxy controller never read it. Users configuring
private-registry credentials silently got no effect: the proxy-runner
Deployment and ServiceAccount were created with no image pull secrets
and image pulls failed against authenticated registries.

Mirror the MCPServer wiring: extract ImagePullSecrets from
ResourceOverrides via a small helper and apply it to both the
proxy-runner ServiceAccount (through rbac.EnsureRBACResourcesParams)
and the Deployment pod spec.

Add TestMCPRemoteProxyEnsureRBACResources_ImagePullSecrets covering
both surfaces.

Fixes #5099

Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Coverage Stats

11 of 11 new or added lines in 2 files covered. (100.0%)

41 existing lines in 5 files now uncovered.

60435 of 94558 relevant lines covered (63.91%)

57.68 hits per line