dangernoodle-io / TaipanMiner / 25091203672

90%

push

github

refactor: eliminate duplicate snapshot allocation in /api/knot handler (#258)

Change build_knot_json to walk knot_peer_t directly instead of requiring
an intermediate knot_snapshot_t wrapper. This eliminates ~8KB of duplicate
transient allocation in the knot_handler stack frame. The function signature
changes from:
  build_knot_json(const knot_snapshot_t *s, bb_json_t root)
to:
  build_knot_json(const knot_peer_t *peers, size_t n_peers, int64_t now_us, bb_json_t root)

Field mapping (knot_peer_t -> JSON) is now done at write time:
- instance_name -> "instance"
- ip4 -> "ip"
- all other fields match directly

The JSON output shape is identical to before. Host tests updated to construct
knot_peer_t arrays directly. build_knot_json is more flexible and avoids
memcpy loops in the handler path.

Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>

586 of 698 branches covered (83.95%)

Branch coverage included in aggregate %.

6 of 6 new or added lines in 1 file covered. (100.0%)

1360 of 1396 relevant lines covered (97.42%)

298004.69 hits per line