maximunited / imou_life / 25079207558

90%

Build Type

push

github

Committed by web-flow

Commit Message

Refactor battery optimization and fix critical security issues (#8)

* feat: add CLAUDE.md and integrate Karpathy Guidelines

- Add comprehensive CLAUDE.md with project architecture and dev commands
- Install Karpathy Guidelines as git submodule for code quality
- Add .claude/skills/ documentation and setup instructions
- Update .gitignore to exclude local settings and junctions
- Clean up README.md version compatibility section
- Fix translation structure: data_description ? description in ca.json
- Add superpowers plugin configuration

The Karpathy Guidelines provide behavioral rules to reduce common
LLM coding mistakes: Think Before Coding, Simplicity First,
Surgical Changes, and Goal-Driven Execution.

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

* feat: refactor battery optimization and fix critical issues

Battery Optimization Refactoring:
- Create ImouBatteryEntity base class to eliminate code duplication
- Remove unittest.mock from production code (was incorrectly used)
- Fix hardcoded mock data - now uses real coordinator data
- Complete API integration with proper fallback handling
- Add asyncio.Lock for thread-safe state mutations
- Make battery optimization methods public (enter_sleep_mode, exit_sleep_mode, etc.)
- Add public API wrappers for coordinator methods
- Use cached battery data to avoid redundant API calls
- Fix type hints: Dict[str, str] ? Dict[str, Any]

Critical Security and Error Handling Fixes:
- SECURITY: Remove hardcoded credentials from camera.py (rtsp://admin:yourpassword@...)
- Fix exception handling in __init__.py - preserve original exception context
- Add error message to UpdateFailed in coordinator.py for better debugging
- Add input validation for timeout parsing with try/except
- Use ValueError instead of generic Exception in switch.py

Test Updates:
- Update all battery tests to work with new base class
- Add AsyncMock for async_get_battery_status in conftest
- Fix method names: _enter_sleep_mode ? ... (continued)

Coverage Stats

164 of 232 new or added lines in 9 files covered. (70.69%)

6 existing lines in 3 files now uncovered.

796 of 1162 relevant lines covered (68.5%)

2.06 hits per line