Tatsh / pychoco / 25070415960

100%

push

github

project: accept abstract collections in public APIs

Widen parameter types from concrete `dict` to abstract `Mapping`/
`MutableMapping` so callers can pass any compatible mapping. Defensive
copy in `ChocolateyClient.__init__` prevents the caller's dict from
being mutated by later `add_key`/`config_set` calls.

- utils.entry_to_search_result: ns -> Mapping[str, str]
- config.write_api_keys: api_keys -> Mapping[str, str]
- client.ChocolateyClient.__init__: api_keys -> Mapping[str, str] | None
  with `dict(api_keys)` defensive copy into self.api_keys
- client._process_pages: ns -> Mapping[str, str], results ->
  MutableMapping[str, SearchResult]

Backward compatible: dict satisfies Mapping, so existing callers
continue to work. xml.etree.ElementTree.Element.find requires dict, so
ns is converted once at the top of each function.

Signed-off-by: Andrew Udvare <audvare@gmail.com>

35 of 35 branches covered (100.0%)

Branch coverage included in aggregate %.

15 of 15 new or added lines in 3 files covered. (100.0%)

588 of 588 relevant lines covered (100.0%)

5.0 hits per line