kubevirt / containerized-data-importer / #5967

50%

push

travis-ci

VDDK: search root snapshot backing file chain for target disk (#4055)

* VDDK: search backing file chain more thoroughly

VMware VMs can have multiple levels of backing file parents, if it had
snapshots that were deleted but not yet consolidated into one file.
This changes searches through this chain for the target file, up to an
arbitrary limit.

Signed-off-by: Matthew Arnold <marnold@redhat.com>

* VDDK: add tests for multiple parent backing files

Rework the existing tests to make it easier to build the backing file
chains, and add three new tests to validate the new search.

Signed-off-by: Matthew Arnold <marnold@redhat.com>

* VDDK: disambiguate snapshot disk file lookup test

Previously, it was not clear if this test was testing a target disk
search through multiple snapshots, or an unconsolidated backing file
chain on a single snapshot. This changes the test to handle both.

Signed-off-by: Matthew Arnold <marnold@redhat.com>

* Split up and flatten FindDiskInRootSnapshotParent

This should reduce complexity rating in CI.

Signed-off-by: Matthew Arnold <marnold@redhat.com>

* Further flatten search to reduce complexity rating.

Signed-off-by: Matthew Arnold <marnold@redhat.com>

* Remove extraneous comment.

Signed-off-by: Matthew Arnold <marnold@redhat.com>

* Check expected error message in unit test.

Signed-off-by: Matthew Arnold <marnold@redhat.com>

---------

Signed-off-by: Matthew Arnold <marnold@redhat.com>

62 of 72 new or added lines in 1 file covered. (86.11%)

14988 of 30198 relevant lines covered (49.63%)

0.56 hits per line