stacklok / toolhive / 25062537185

66%

Build Type

push

github

Committed by web-flow

Commit Message

thv llm: complete setup/teardown orchestration (#5068)

* thv llm: complete setup/teardown orchestration

Add the missing pieces that turn the adapter scaffolding into a working
end-to-end flow:

- thv llm setup now accepts inline --gateway-url / --issuer / --client-id
  (and the other config flags) so "config set" and "setup" can be combined
  in a single command. Flags are merged into the persisted config before
  the rest of setup runs.

- setup triggers an interactive OIDC browser login after configuring all
  detected tools, so the refresh token is stored before any tool or proxy
  tries to use it.

- setup starts the localhost proxy as a background process when any
  proxy-mode tool (Cursor, VS Code, Xcode) was configured, and saves the
  PID to config so teardown can stop it.

- teardown sends SIGINT to the stored proxy PID (if any) before clearing
  the PID from config. The PID is always zeroed in the final UpdateConfig
  call regardless of whether the signal succeeded.

- pkg/llm.ProxyConfig gains a PID field (yaml/json: "pid") to hold the
  background proxy process ID across CLI invocations.

E2E tests in cli_llm_setup_test.go cover: inline-flag config + tool
patching, full teardown revert, single-tool targeted teardown, no-config
error, and --purge-tokens token cleanup.

Fixes #5031

* thv llm: complete setup/teardown orchestration

- setup accepts inline --gateway-url / --issuer / --client-id (and the
  other config flags), merged into persisted config before running, so
  config-set and setup can be combined in a single invocation
- OIDC browser login runs after tool config files are patched so the
  refresh token is cached before tools use it; proxy-mode tools receive
  a hint to run "thv llm proxy start" (foreground command, no daemon)
- teardown reverts all (or a single named) tool config patches;
  --purge-tokens deletes cached OIDC tokens from the secrets provider
- loginFunc injected into runLLMSetup for keyring-free unit tests
- pu... (continued)

Coverage Stats

24 of 79 new or added lines in 1 file covered. (30.38%)

4 existing lines in 2 files now uncovered.

60462 of 94551 relevant lines covered (63.95%)

57.23 hits per line