supabase / supautils / 25060946321

89%

push

github

fix: crash in supautils_executor_start

`supautils_executor_start` makes some assumptions about the `ERROR` it is intercepting. Following are addressed:

- Fixed cases where the target object isn't a relation
- Fixed possible cases of trying to free a `NULL` variable
- Fixed possible leak of an old hint (if there were one)

This fixes existing bugs. However it doesn't add the missing functionality for the cases when privileges are missing for functions, schemas etc.

I also want to point out that executor is a very low level API and hooking into it merely to slightly improve user experience seems like an overkill to me. We could consider writing a standalone function to the effect of `check_permissions(objclassid, objid, rolename)` that would perform the same checks as the hook, but won't reside in a critical codepath so any potential bugs won't crash the database.

15 of 15 new or added lines in 1 file covered. (100.0%)

1101 of 1240 relevant lines covered (88.79%)

32.18 hits per line