stacklok / toolhive / 25056310871

66%

Build Type

push

github

Committed by web-flow

Commit Message

Strengthen tool detection with binary presence check (#5083)

DetectedLLMGatewayClients() previously detected an installed AI tool by
checking whether its settings directory exists on disk. This produced
false positives when directories like ~/.claude or ~/.gemini were left
over from a prior uninstall or created by unrelated tooling.

Add an optional LLMBinaryName field to clientAppConfig. When set,
DetectedLLMGatewayClients() now requires both the settings directory
and the binary on $PATH (via exec.LookPath) before considering a tool
installed. Tools not on $PATH (e.g. Xcode, a macOS GUI app) leave the
field empty and fall back to the directory-only check.

Populate LLMBinaryName for claude-code ("claude"), gemini-cli ("gemini"),
cursor ("cursor"), vscode ("code"), and vscode-insider ("code").

Closes #5070

Co-authored-by: taskbot <taskbot@users.noreply.github.com>

Coverage Stats

7 of 8 new or added lines in 2 files covered. (87.5%)

12 existing lines in 4 files now uncovered.

60215 of 94176 relevant lines covered (63.94%)

58.98 hits per line