jumpinjackie / mapguide-react-layout / 25054557061

60%

Build Type

push

github

Committed by web-flow

Commit Message

Complete ElementContext abstraction for Toaster, Dialog, and RndModalDialog (#1634)

* Initial plan

* feat: add Toaster and Dialog to ElementContext abstraction

- Define IToasterRef, ToastMessage, ToastPosition, ToasterProps and DialogProps
  types in element-context.tsx
- Add Toaster (forward-ref) and Dialog to IElementContext interface
- Create BpToaster in providers/blueprint/toaster.tsx using useImperativeHandle
  to bridge the abstract IToasterRef API to Blueprint's Toaster
- Create BpDialog in providers/blueprint/dialog.tsx wrapping Blueprint Dialog
- Wire BpToaster and BpDialog into the Blueprint provider
- Update neo-map-viewer.tsx to use Toaster from useElementContext() instead of
  direct @blueprintjs/core import
- Update init-warning-display.tsx to use Dialog from useElementContext()
- Update base.ts to use IToasterRef instead of Blueprint Toaster type
- Update test mocks in neo-and-quick-plot.spec.tsx and
  container-wrappers.spec.tsx to include the new Toaster/Dialog context entries

Agent-Logs-Url: https://github.com/jumpinjackie/mapguide-react-layout/sessions/7f20c268-6be0-4d89-b12e-d526e3689df5

Co-authored-by: jumpinjackie <563860+jumpinjackie@users.noreply.github.com>

* fix: add displayName to BpToaster and BpDialog for React DevTools

Agent-Logs-Url: https://github.com/jumpinjackie/mapguide-react-layout/sessions/7f20c268-6be0-4d89-b12e-d526e3689df5

Co-authored-by: jumpinjackie <563860+jumpinjackie@users.noreply.github.com>

* chore: remove leftover @blueprintjs/core mocks from test files

The Blueprint Toaster/Dialog/Position mocks in container-wrappers.spec.tsx
and neo-and-quick-plot.spec.tsx are now dead code since those components
are consumed through useElementContext() — already mocked in the same files.

Agent-Logs-Url: https://github.com/jumpinjackie/mapguide-react-layout/sessions/483bc7bb-3225-46b3-8197-1c3465931caf

Co-authored-by: jumpinjackie <563860+jumpinjackie@users.noreply.github.com>

* feat(stories): add Toaster... (continued)

Coverage Stats

3098 of 3742 branches covered (82.79%)

45 of 122 new or added lines in 7 files covered. (36.89%)

1 existing line in 1 file now uncovered.

15255 of 25208 relevant lines covered (60.52%)

11.63 hits per line