• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

rollandf / network-operator / 25053291677
62%

Build:
DEFAULT BRANCH: master
Ran 28 Apr 2026 12:43PM UTC
Jobs 1
Files 63
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

27 Apr 2026 07:42PM UTC coverage: 62.302% (+0.3%) from 61.975%
25053291677

push

github

web-flow
fix: backfill ds-owner label on OFED pods when upgrading from GA rele… (#2493)

…ases

When upgrading from a GA release (e.g. v26.1) to v26.4+, existing MOFED
pods lack the ds-owner label that was added to the pod template in
v26.4. Because the DaemonSet uses OnDelete update strategy, these pods
are never recreated automatically and retain their original label set.

The upgrade controller calls BuildState with both nvidia.com/ofed-driver
and ds-owner label selectors. With no pods matching the combined
selector, BuildState errors with "driver DaemonSet should not have
Unscheduled pods" on every reconcile, preventing ApplyState from ever
running and causing the upgrade to stall indefinitely.

Add handleMissingDSOwnerLabelOnPods to the migration path. It runs at
operator startup before any controller is unblocked (MigrationCh gate),
finds OFED pods that lack ds-owner, and patches them with the correct
NicClusterPolicy CRD name. This is a no-op on v26.4+ upgrades where all
pods already carry the label.

25 of 35 new or added lines in 1 file covered. (71.43%)

707 existing lines in 24 files now uncovered.

4887 of 7844 relevant lines covered (62.3%)

44.55 hits per line

Uncovered Changes

Lines Coverage ∆ File
10
60.59
2.81% pkg/migrate/migrate.go

Coverage Regressions

Lines Coverage ∆ File
197
35.95
-12.67% controllers/upgrade_controller.go
107
44.43
1.17% api/v1alpha1/zz_generated.deepcopy.go
93
73.17
-0.04% pkg/state/state_ofed.go
51
0.0
0.0% hack/release.go
45
84.13
0.43% pkg/state/state_skel.go
35
82.05
6.21% controllers/nicclusterpolicy_controller.go
35
71.32
0.25% pkg/state/factory.go
30
0.0
0.0% main.go
24
71.15
-0.27% pkg/state/state_rdma_shared_device_plugin.go
24
71.15
-0.27% pkg/state/state_sriov_dp.go
7
74.63
-2.61% controllers/drain_controller.go
6
75.69
-0.69% pkg/drain/drain_requestor.go
6
56.84
0.0% pkg/state/state_ib_kubernetes.go
6
57.14
0.41% pkg/state/state_multus_cni.go
6
75.44
0.22% pkg/state/state_nic_configuration_operator.go
5
78.18
0.2% pkg/state/state_doca_telemetry_service.go
5
70.87
0.29% pkg/state/state_ipoib_cni.go
5
75.93
0.22% pkg/state/state_nv_ipam_cni.go
5
71.72
0.29% pkg/state/state_spectrumx.go
4
77.55
0.23% pkg/state/state_cni_plugins.go
4
56.38
0.47% pkg/state/state_nic_feature_discovery.go
3
92.65
-0.46% api/v1alpha1/nicclusterpolicy_types.go
2
62.67
3.29% controllers/predicate.go
2
94.59
0.0% pkg/render/render.go
Jobs
ID Job ID Ran Files Coverage
1 25053291677.1 28 Apr 2026 12:43PM UTC 63
62.3
GitHub Action Run
Source Files on build 25053291677
  • Tree
  • List 63
  • Changed 28
  • Source Changed 24
  • Coverage Changed 27
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Repo
  • Github Actions Build #25053291677
  • a065a276 on github
  • Prev Build on master (#23783142992)
  • Delete
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc