dunglas / mercure / 25045912896

84%

master: 93%

push

github

feat(chart): support readOnlyRootFilesystem out of the box (#1226)

* feat(chart): mount /config and /tmp so readOnlyRootFilesystem works

Caddy writes autosave config under XDG_CONFIG_HOME=/config, and /tmp is
useful general-purpose scratch. Until now both were just the rootfs
writable layer, so `securityContext.readOnlyRootFilesystem: true` would
crash the pod on first write.

Mount /config and /tmp as emptyDir unconditionally. /data stays
conditional on persistence (existing behaviour); under
`readOnlyRootFilesystem: true` with the default BoltDB transport,
enable persistence so /data is a writable PVC. Other transports
(Redis, etc.) do not touch /data, so RO rootfs works out of the box.

Documents the chart's rootless+RO-rootfs example in docs/hub/install.md.

* fix(bolt): create the data directory if missing

When the bolt transport's path resolves to a fresh emptyDir or PVC, the
parent directory does not exist (the host image's pre-created
`/data/caddy` is masked by the mount), and `bolt.Open` fails with
`open .../mercure.db: no such file or directory`.

`MkdirAll` the parent in `NewBoltTransport`, before opening the file,
so any caller of the lib (not just the Caddy module) is covered.
No-op when the directory already exists.

4 of 6 new or added lines in 1 file covered. (66.67%)

1747 of 2084 relevant lines covered (83.83%)

49.8 hits per line