stacklok / toolhive-studio / 25042235479

70%

push

github

feat(skills): persist build dialog errors inline instead of an ephemeral toast (#2123)

* test(mocks): register user-error scenario for 400 backend errors

Add a generic 'user-error' entry to MockScenarios so fixtures can model the 400 Bad Request shape introduced for the skill-build endpoint by stacklok/toolhive#5076, and wire the first instance on POST /api/v1beta/skills/build returning '{ error: "SKILL.md missing" }'.

* feat(skills): persist build dialog errors inline instead of an ephemeral toast

Render a destructive Alert below the dialog header that surfaces the backend message verbatim — including the actionable 400 packager errors from stacklok/toolhive#5076 (SKILL.md missing, invalid SKILL.md frontmatter, symlink/size violations) — so the user can keep reading it while they fix the path or tag. The alert clears on cancel and on resubmit. Mirrors the submitError pattern already used by DialogInstallSkill.

* refactor(skills): drop redundant error toast from build mutation hook

The build dialog now owns the user-visible error surface with an inline alert that preserves the backend message, so the hook's generic 'Failed to build skill' toast was duplicating the signal and hiding the more useful packager output. trackEvent('Skills: build failed') is preserved — analytics are unchanged. Matches useMutationInstallSkill, which already lets its dialog render the error inline.

3903 of 6381 branches covered (61.17%)

6 of 6 new or added lines in 1 file covered. (100.0%)

6006 of 9032 relevant lines covered (66.5%)

126.88 hits per line