|
Ran
|
Jobs
1
|
Files
525
|
Run time
2min
|
Badge
README BADGES
|
push
github
iproto: fix double-free of user name with multiple serving threads When an IPROTO connection is created with `box.session.new()`, we store a pointer to the same user name in each serving thread's runtime credentials. Thus when the connection is deleted, the same user name will be freed multiple times (once for each serving thread), which is a bug. Let's fix it by creating a copy of the user name for each serving thread. The bug slipped through because luatest didn't detect bugs reported by the address sanitizer at exit, see tarantool/luatest#460. Closes #12631 NO_DOC=bug fix NO_TEST=covered by existing tests (cherry picked from commit 805df52ff)
70760 of 119060 branches covered (59.43%)
5 of 5 new or added lines in 1 file covered. (100.0%)
31 existing lines in 15 files now uncovered.106415 of 121343 relevant lines covered (87.7%)
1346357.53 hits per line
| Lines | Coverage | ∆ | File |
|---|---|---|---|
| 8 |
60.42 |
-3.55% | src/lib/core/fio.c |
| 3 |
92.0 |
-0.3% | src/box/vy_scheduler.c |
| 3 |
97.05 |
-0.2% | src/lib/msgpuck/msgpuck.h |
| 2 |
91.54 |
-0.06% | src/box/box.cc |
| 2 |
96.2 |
-0.09% | src/box/iproto.cc |
| 2 |
92.65 |
-0.04% | src/box/vinyl.c |
| 2 |
87.96 |
0.0% | src/box/vy_run.c |
| 2 |
93.81 |
-0.03% | src/box/xrow_update_field.c |
| 1 |
91.98 |
-0.2% | src/box/gc.c |
| 1 |
96.32 |
-0.18% | src/box/relay.cc |
| 1 |
95.0 |
-0.1% | src/box/replication.cc |
| 1 |
95.74 |
1.6% | src/box/vy_range.c |
| 1 |
95.01 |
-0.21% | src/box/vy_read_iterator.c |
| 1 |
71.97 |
-0.2% | src/lib/core/popen.c |
| 1 |
97.41 |
-0.86% | src/lib/vclock/vclock.c |
| ID | Job ID | Ran | Files | Coverage | |
|---|---|---|---|---|---|
| 1 | 25040624487.1 | 525 |
87.7 |
GitHub Action Run |
| Coverage | ∆ | File | Lines | Relevant | Covered | Missed | Hits/Line | Branch Hits | Branch Misses |
|---|